Merge pull request #41 from hpxro7/bug/shuffle

Fixed incorrect instance shuffling algorithm.
sjwhitworth · Jun 6, 2014 · 8cc8aea · 8cc8aea
2 parents e5a9ae4 + a54d473
commit 8cc8aea
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/base/instances.go b/base/instances.go
@@ -5,8 +5,9 @@ import (
 	"encoding/binary"
 	"errors"
 	"fmt"
-	"github.com/gonum/matrix/mat64"
 	"math/rand"
+
+	"github.com/gonum/matrix/mat64"
 )
 
 // SortDirection specifies sorting direction...
@@ -507,7 +508,7 @@ func (inst *Instances) GeneratePredictionVector() *Instances {
 // Shuffle randomizes the row order in place
 func (inst *Instances) Shuffle() {
 	for i := 0; i < inst.Rows; i++ {
-		j := rand.Intn(inst.Rows)
+		j := rand.Intn(i + 1)
 		inst.swapRows(i, j)
 	}
 }