contrib: add community contrib feature #79
Conversation
|
等待上游分支合并后再结束 draft 状态。 |
|
贡献的 PR 可以添加 |
|
插件化工作还在进行中。下面是一些暂时思考到的一些想法。 贡献子主题/插件的意义：
插件化工作的意义：
|
|
目前的添加插件的流程：
|
|
目前考虑到的要review什么：
|
|
目前能够考虑到的类型：
|
|
内核还要做什么：
|
LogCreative
force-pushed
the
logcreative-contrib
branch
from
85e6de8
to
05a8a94
Compare
This reverts commit f39a811.
This comment has been minimized.
This comment has been minimized.
|
我觉得创建一个 good first issue 后 改一下yaml 可以合并了 |
成功！晚点一定（ |
|
yaml 多看看 我不知道对不对（push还没试 |
|
👍 不好意思啊，我前段时间在准备考试，我考完试来看看 |
| ) | ||
| }} | ||
| - uses: jungwinter/comment@v1 | ||
| if: github.event_name == 'push' |
There was a problem hiding this comment.
Do we really need to comment on pushes? I would prefer only doing comments on pull-requests.
There was a problem hiding this comment.
The intention here is to make a collection of templates in an issue so that the user could select the theme in an easier way. Since the doc of the plug-in will not be included in the repo. It is a workaround for that.
There was a problem hiding this comment.
And it has not been tested.
| id: contrib_png | ||
| with: | ||
| path: ./build/contrib.*.png | ||
| client_id: ${{secrets.IMGUR_CLIENT_ID}} |
There was a problem hiding this comment.
Everyone who creates PR can now access this secret. Is it expected?
There was a problem hiding this comment.
It seems that if someone pulls a request, then collaborator approves it, the secret could be accessed. (idk)
|
如果 @cascades-sjtu 感兴趣的话，可以发个 issue 用于整合，然后修改 yaml 里的 issue 号，这个分支就可以合并了 |
|
Thank you for contributing to SJTUBeamer! Here is the preview of your contribution documentation. |
|
那我发 issue 准备合并了（ |
|
滋瓷！ |
|
ci 我再修修 试试一些功能后 争取过年后 release（ |
建设社区
希望添加一个
good first issue来提高社区建设：开发者可以向根目录下的contrib目录添加自定义的模板（子主题）。并添加内置指令\getcontribdir{#1}获得#1主题的文件夹目录\getcontribpath{#1}{#2}获得#1主题的文件夹#2文件路径\usemytheme{#1}使用#1子主题，在加载sjtubeamer主要主题后使用\definelogo添加一个可选参数用于接受文件夹路径这样就可以固化一些社区贡献模板，每一个文件夹就是一个小工作区，可以添加一些自定义图片，环境有了隔离。并且并没有离开 sjtubeamer 的开发环境，可以
sjtucover和sjtuvi的所有工具\EqualOption{}{}{}可以判断其他文件的参数情况，由于\usemytheme在主要主题入口文件定义，不能在仅加载inner或outer主题时使用my主题，也就意味着整个主模板在完整加载的状态。sjtucover中但是加载参数可以通过内部接口传递。.ltx文件并不能接受参数，希望添加其他参数应该向内核提供 PR。（或者等我想到了更好地传递参数方法，我觉得可以不允许添加额外的子模板参数，这样可以保证整体的统一性）而 Release 时不会放入这些contrib文件夹，直接下载 Code 会下载这些社区贡献子主题。（这样就更应该下载 Release 了）