-
Notifications
You must be signed in to change notification settings - Fork 43
Test that the TypeScript files in our tests actually compile with tsc #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
4c9d3c8
add typescript test
kyo-ago 8759378
Add slash to gitignore
kyo-ago 80e14b8
Use fixed version in travis.yml
kyo-ago 550130d
Add .d extension to travis.yml
kyo-ago 0ad61c7
Fix nvm install version
kyo-ago 5b6c1b8
Rename .ts to .d.ts
kyo-ago ad2f528
Fix samples/extendsobject.d.ts(4,2): error TS1036: Statements are not…
kyo-ago 66b60b1
Rename .ts to .d.ts
kyo-ago File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,3 +5,5 @@ target/ | |
.classpath | ||
.project | ||
.settings/ | ||
/node_modules | ||
/package-lock.json |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
declare module "module" { | ||
const value: any; | ||
export const Single: any; | ||
export const First: any; | ||
export const Second: any; | ||
export const Third: any; | ||
export const Fourth: any; | ||
export const Fifth: any; | ||
export default value; | ||
} |
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,4 @@ | ||
// copy from https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/lodash/index.d.ts | ||
declare interface LoDashStatic { | ||
at<T extends object>(); | ||
}; | ||
|
||
} |
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
/// <reference path="./assets/module" /> | ||
// Import variants from https://www.typescriptlang.org/docs/handbook/modules.html#import | ||
|
||
import Default from "module"; | ||
import { Single } from "module"; | ||
import { Single as Renamed } from "module"; | ||
import { First, Second } from "module"; | ||
import { Third as T, Fourth } from "module"; | ||
import * as validator from "module"; | ||
import "./assets/module"; | ||
|
||
declare const hello: String; | ||
|
||
declare module mod { | ||
export function f(x: Number): String; | ||
} |
File renamed without changes.
This file was deleted.
Oops, something went wrong.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,7 +10,7 @@ declare module overrides { | |
toString(): string; | ||
} | ||
|
||
export class B extends BLike { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
export class B implements BLike { | ||
equals(other: any): boolean; | ||
clone(): BLike; | ||
toString(): string; | ||
|
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this standard practice? Is not dangerous? As in, if a new version of the CI script does not install some package anymore, it would still be in the cached
node_modules/
, and would therefore still be available, by accident?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is the standard practice.
Caching Dependencies and Directories - Travis CI
The Travis CI Blog: Speed Up Your Builds: Cache Your Dependencies
But I can understand your concerns as well. Do you want to delete it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK let's keep it that way, then.