Add support for graphene-django v3 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was officially released on Sep 26, 2022 https://github.com/graphql-python/graphene-django/releases/tag/v3.0.0
This is the default for testing utils in graphene-django v3, so we can switch to that rather than updating our test settings.
…ning
Otherwise we encounter this warning:
```
graphene/utils/subclass_with_meta.py:46: DeprecationWarning: Creating a DjangoObjectType without either the `fields` or the `exclude` option is deprecated. Add an explicit `fields = '__all__'` option on DjangoObjectType User to use all fields
super_class.__init_subclass_with_meta__(**options)
```
sjdemartini
force-pushed
the
graphene-django-v3
branch
from
118c357
to
746808e
Compare
Only encountered this in CI, where poetry 1.2 started getting installed (https://github.com/sjdemartini/graphene-django-permissions/actions/runs/3284716438/jobs/5411001549), since originally I was using Poetry 1.1 locally: ``` poetry.core.constraints.version.exceptions.ParseConstraintError: Could not parse version constraint: ^3.0.0* ``` Poetry 1.2 (released August 2022) contained a backwards incompatible change for `allow-preleases` logic, which led to this breakage (and difference from 1.1). See python-poetry/poetry#3538 (comment) for the new preferred approach.
The new 3.0.2 release includes a fix for the SQL query performance regression https://github.com/graphql-python/graphene-django/releases/tag/v3.0.2 (graphql-python/graphene-django#1401) which was causing test failures on this branch.
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #5 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 33 33
Branches 10 8 -2
=========================================
Hits 33 33
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2
graphene-django v3 was officially released https://github.com/graphql-python/graphene-django/releases/tag/v3.0.0, so this branch attempts to add support for it.
Currently outstanding / preventing merge: