fix(ecs): update driverOpts type definition from array to map (aws#3358)

* fix(ecs): driverOpts type definition * fix(ecs): add driverOpts to allowed-breaking-changes.txt * fix(ecs): fix allowed-breaking-changes * fix(ecs): remove bracket in allowed-breaking-changes.txt
sjagvi · Aug 9, 2019 · 65e4a5d · 65e4a5d
1 parent 24ebec8
commit 65e4a5d
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 3 deletions.
diff --git a/allowed-breaking-changes.txt b/allowed-breaking-changes.txt
@@ -1,3 +1,9 @@
+incompatible-argument:@aws-cdk/aws-ecs.Ec2TaskDefinition.<initializer>
+incompatible-argument:@aws-cdk/aws-ecs.Ec2TaskDefinition.addVolume
+incompatible-argument:@aws-cdk/aws-ecs.FargateTaskDefinition.<initializer>
+incompatible-argument:@aws-cdk/aws-ecs.FargateTaskDefinition.addVolume
+incompatible-argument:@aws-cdk/aws-ecs.TaskDefinition.<initializer>
+incompatible-argument:@aws-cdk/aws-ecs.TaskDefinition.addVolume
 change-return-type:@aws-cdk/core.Fn.getAtt
 new-argument:@aws-cdk/aws-iam.ManagedPolicy.<initializer>
 new-argument:@aws-cdk/aws-iam.ManagedPolicy.<initializer>
diff --git a/packages/@aws-cdk/aws-ecs/lib/base/task-definition.ts b/packages/@aws-cdk/aws-ecs/lib/base/task-definition.ts
@@ -484,7 +484,7 @@ export interface DockerVolumeConfiguration {
    *
    * @default No options
    */
-  readonly driverOpts?: string[];
+  readonly driverOpts?: {[key: string]: string};
   /**
    * Custom metadata to add to your Docker volume.
    *

diff --git a/packages/@aws-cdk/aws-ecs/test/ec2/test.ec2-task-definition.ts b/packages/@aws-cdk/aws-ecs/test/ec2/test.ec2-task-definition.ts
@@ -520,7 +520,10 @@ export = {
         name: "scratch",
         dockerVolumeConfiguration: {
           driver: "local",
-          scope: ecs.Scope.TASK
+          scope: ecs.Scope.TASK,
+          driverOpts: {
+            key1: "value"
+          }
         }
       };
 
@@ -540,7 +543,10 @@ export = {
           Name: "scratch",
           DockerVolumeConfiguration: {
             Driver: "local",
-            Scope: 'task'
+            Scope: 'task',
+            DriverOpts: {
+              key1: "value"
+            }
           }
         }]
       }));