Fix error with duplicate config keys on different queries #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
we encountered an error with the jmx plugin and the config. If two different queries return the same name parameters then the plugin renames both with one of the configured labels.
Example:
I have the following config:
{ "type": "jvm", "queries": [ { "object": "java.lang:type=OperatingSystem", "attributes": [ { "name": "SystemCpuLoad", "label": "tph_jvm_os_systemCpuLoad" }, { "name": "ProcessCpuLoad", "label": "tph_jvm_os_processCpuLoad" } }, { "object": "java.lang:type=OperatingSystemParent", "attributes": [ { "name": "SystemCpuLoad", "label": "tph_jvm_parent_systemCpuLoad" }, { "name": "ProcessCpuLoad", "label": "tph_jvm_parent_processCpuLoad" } } ] }In Graylog I would only receive the values:
tph_jvm_parent_systemCpuLoad
tph_jvm_parent_processCpuLoad
but it could be that the values are from the HostOS and not the parent.
The reason is that the key replacements are handled in a HashMap without using the query (only the Name) - the fix is this PR.
Thanks!