refactor: Migration from Survey to Charm huh
#30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harsh4902 <harshparmar4902@gmail.com>
Signed-off-by: Harsh4902 <harshparmar4902@gmail.com>
|
Thanks for the PR @Harsh4902 |
| Validate(func(str string) error { | ||
| return helpers.ValidateApplicationName(str) | ||
| }). | ||
| Value(&answers.AppName), |
There was a problem hiding this comment.
To retain the existing behavior of providing "Default" values, we can initialize answers := ProjectConfig{} with default values.
generators/spring-boot/prompts.go
Outdated
| Default: []string{"Spring Modulith", "Thymeleaf", "Security"}, | ||
| }, | ||
| }, | ||
| } | ||
| answers := ProjectConfig{} |
There was a problem hiding this comment.
Change answers := ProjectConfig{} to the following:
answers := ProjectConfig{
AppName: "myapp",
GroupID: "com.mycompany",
ArtifactID: "myapp",
AppVersion: "1.0.0-SNAPSHOT",
BasePackage: "com.mycompany.myapp",
BuildTool: "Maven",
DbType: "PostgreSQL",
DbMigrationTool: "Flyway",
Features: []string{"Spring Modulith", "Thymeleaf", "Security"},
}
generators/minimal-java/prompts.go
Outdated
| Default: "Maven", | ||
| }, | ||
| }, | ||
| } | ||
| answers := ProjectConfig{} |
There was a problem hiding this comment.
Replace answers := ProjectConfig{} to the following:
answers := ProjectConfig{
AppName: "myapp",
GroupID: "com.mycompany",
ArtifactID: "myapp",
AppVersion: "1.0.0-SNAPSHOT",
BasePackage: "com.mycompany.myapp",
BuildTool: "Maven",
}
generators/minimal-go/prompts.go
Outdated
| }, | ||
| }, | ||
| } | ||
|
|
||
| answers := ProjectConfig{} |
There was a problem hiding this comment.
Change answers := ProjectConfig{} to the following:
answers := ProjectConfig{
AppName: "myapp",
ModulePath: "github.com/username/myapp",
RoutingLibrary: "Gin",
}
Signed-off-by: Harsh4902 <harshparmar4902@gmail.com>
|
@sivaprasadreddy Yes sir. I was thinking the same, but I was not sure. Thank you for suggesting, I have implemented the changes. |
Signed-off-by: Harsh4902 <harshparmar4902@gmail.com>
sivaprasadreddy
approved these changes
Feb 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
charm huh, and considers migration fromsurveybecause it is not maintained anymore.Changes
huh.form..gitignoreto ignore.DS_Storefile of MacOS.Related Issue(s)
Resolves #13
New CLI