iOS 17 / tvOS 17 / macOS 14 support #243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davdroman It looks like both main and your branch does not run on tvOS 17. |
|
@mikolaj92 please note that's an issue with the old module, This PR and most of the upcoming work you'll see from me will only target the new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can confirm it all works as expected on iOS 17 and tvOS 17
however I can't merge yet because I haven't ran tests on macOS 14.Ran locally on macOS 14, all good.I'm really hoping GitHub Actions adds support for macOS 14 runners soon this year. Xcode 15 can be ran on macOS 13 so it's no problem for running tests on iOS 17 and tvOS 17, but macOS 14 requires the actual OS as a runner image.