Fix parse error, accept header values separated without space #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following example failed:
$ socat - TCP:localhost:1234,crnl
GET / HTTP/1.1
Connection: Upgrade,Keep-Alive
Upgrade: websocket
Sec-WebSocket-Key: hq0S1hpdldRhTHVwXBDPvg==
Sec-WebSocket-Version: 13
Host: localhost:1234
HTTP/1.1 400 Bad Request
$
but would have worked as expected with
Connection: Upgrade, Keep-Alive
|
@sitegui Is there anything missing before you can merge this? |
|
Hello @hlovdal , sorry for missing your PR, it got lost in my inbox. No, it's perfect! Thanks for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following example failed:
but would have worked as expected with