Skip to content

Conversation

@agnesl10
Copy link
Collaborator

  • colors
  • side bar
  • nav bar
  • kinda light to dark mode color matching
  • upload page (sorta)

@agnesl10 agnesl10 linked an issue Nov 12, 2025 that may be closed by this pull request
Copy link
Contributor

@christinac09 christinac09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you make sure all the files are formatted with prettier
and we should figure out dark mode stuff


<style scoped></style>
<style scoped>
.label {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't you do this with tailwind too

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure i can see

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

<button @click="$emit('cancel')" class="rounded bg-gray-200 px-4 py-2 text-gray-700 hover:bg-gray-300">Cancel</button>
<button @click="$emit('confirm')" class="rounded bg-blue-600 px-4 py-2 text-white hover:bg-blue-700">Confirm</button>
<button @click="$emit('cancel')" class="rounded-xl bg-gray-200 px-4 py-2 text-gray-700 hover:bg-gray-300">Cancel</button>
<button @click="$emit('confirm')" class="rounded=xl bg-secondary rounded px-4 py-2 text-white hover:bg-[#3E69A3]">Confirm</button>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change = to -

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

});
</script>

<style scoped>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't you put this in tailwind

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i did most of it, but font family is way too complicated in tailwind so i js left it there

@confirm="deletePhoto(deletePhotoIndex)"
/>
</div>
<div class="uploadnav">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add the nuxtlink to the upload page

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@@ -1,7 +1,20 @@
<template>
<div class="bg-base-200 text-base-content flex min-h-screen items-center justify-center p-6 pt-20">
<div class="dropdown">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this here
its already in navbar

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done


<div class="tooltip" data-tip="Delete">
<button class="btn btn-circle btn-ghost btn-sm content-center text-center" @click="emit('delete')">
<img v-if="store.theme === 'light'" src="/trash-outline.svg" aria-hidden="true" class="h-5 opacity-60 select-none" draggable="false" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for this also this prob isn't the best way to do this we should be using classes

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wdym

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

theres not even any difference between these imgs ??

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeahhh sooo we gotta get the icon problem figured out

<h2 class="mb-6 text-xl font-bold">Filters</h2>
<div v-if="!isCollapsed" class="align-center border-base-300 dark:border-base-300 w-full items-center border-r p-4 shadow-sm">
<div class="header w-full content-center items-center">
<img v-if="store.theme === 'light'" src="/filterlight.svg" class="w-full scale-75 items-center" alt="header" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^

<label class="label dark:invert">
<span class="label-text">Upload Date</span>
<label class="label w-full">
<span v-if="store.theme === 'light'" class="label-text m-4 w-full text-center text-xl tracking-widest text-black">Upload Date</span>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^

<span class="label-text">People (comma-separated)</span>
<div class="w-full content-center items-center">
<label for="people" class="flex w-full flex-col items-center">
<span v-if="store.theme === 'light'" class="mt-4 mb-0 text-xl leading-none tracking-widest text-black">People</span>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^
and doesn't dark:invert does work on most of the text?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no it doesnt---- it kinda broke everything

<button type="button" class="btn btn-xs btn-circle btn-ghost" @click="removePerson(index)">
<img src="/close-outline.svg" aria-hidden="true" class="h-4 opacity-50 select-none dark:invert" draggable="false" />
<div class="contents-center w-full items-center text-center">
<button v-if="store.theme === 'light'" type="reset" class="btn btn-outline-[#779FD3] mb-2 w-full bg-[#779FD3] text-center font-normal text-white hover:bg-[#567CAD]" @click="resetInputs">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^

<label :for="category" class="label dark:text-neutral-content">
<span class="label-text dark:invert">{{ category }}</span>
<label :for="category" class="label">
<span v-if="store.theme === 'light'" class="label-text text-[#5d6a7b]">{{ category }}</span>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://tailwindcss.com/docs/dark-mode#toggling-dark-mode-manually
and whenever the theme changes, just toggle the dark class on document.body
and then u can just do text-wtv dark:text-wtv

but yea definitely do not make separate elements just for dark mode

</div>
<div class="navbar-center">
<a class="btn btn-ghost text-xl">TimeCapsule</a>
<img v-if="store.theme === 'light'" src="/logo.svg" alt="logo" class="scale-85" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can just change the src instead of rendering new element

<img :src="store.theme === 'light' ? '/logo.svg' : '/logodark.svg'" ... />


<div class="tooltip" data-tip="Delete">
<button class="btn btn-circle btn-ghost btn-sm content-center text-center" @click="emit('delete')">
<img v-if="store.theme === 'light'" src="/trash-outline.svg" aria-hidden="true" class="h-5 opacity-60 select-none" draggable="false" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

theres not even any difference between these imgs ??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

layout & design (not all pages)

4 participants