Add tooltip to truncated bookmark titles #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-s
force-pushed
the
up-link-title
branch
from
465937e
to
7472c10
Compare
bookmarks/styles/bookmark-page.scss
Outdated
| @@ -122,6 +122,22 @@ li[ld-bookmark-item] { | |||
| white-space: nowrap; | |||
| overflow: hidden; | |||
| text-overflow: ellipsis; | |||
|
|
|||
| &[data-title]:hover::after { | |||
There was a problem hiding this comment.
While this is a neat trick, it's super annoying that this immediately pops up when you hover over a link.
I would be more open to using the regular title attribute.
There was a problem hiding this comment.
@sissbruecker I hear you. I force-pushed a new commit which makes two amendments.
- The pop-up will only show if the text is partially hidden.
- There is a ~300ms delay before the pop-up shows up.
There was a problem hiding this comment.
Thanks. Did some tweaks:
- Restrict tooltip max width to bookmark item so longer titles don't overflow
- Make tooltip show up on focus, for example when using keyboard navigation
- Refactored JS so that it reuses existing bookmark item behavior, doesn't need to duplicate title into a data attribute
- Refactored CSS to reuse Spectre CSS variables
jonathan-s
force-pushed
the
up-link-title
branch
from
7472c10
to
0730cc7
Compare
sissbruecker
changed the title
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #606
This is what it looks like with a custom hover over a link that has an overly long title.
Light theme.
