Add option to share bookmarks publicly #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a setting that allows public / anonymous access to shared bookmarks. As part of this the permissions for the shared bookmarks view and API route have been changed so that they can be accessed without login. However, both will only return bookmarks to anonymous users if:
Once the new setting is enabled every shared bookmark becomes publicly accessible - it is not possible to control the access level per bookmark. Disabling either setting will hide bookmarks from public access again. Every information about a bookmark is shared, including notes.
To actually share bookmarks with anonymous users, provide them with a link to the shared bookmarks page, optionally with preset filters for user, search terms or tags. For discoverability, the login view now shows a link to the shared bookmarks page if at least one user has a publicly shared bookmark.
Closes #491
Closes #255
Closes #70