Merge pull request #70 from sisoputnfrba/56-config-segfault-double-ne…

…wline

Halt string_split tokenization if there are no more tokens

src/commons/string.c

@@ -258,6 +258,9 @@ char** _string_split(char* text, char* separator, bool(*condition)(char*, int))
 
 	while(condition(next, size)) {
 		char* token = strtok_r(str, separator, &next);
+		if(token == NULL) {
+			break;
+		}
 		str = NULL;
 		size++;
 		substrings = realloc(substrings, sizeof(char*) * size);

tests/unit-tests/resources/config-double-newline.cfg

@@ -0,0 +1,17 @@
+# This is the IP
+IP=127.0.0.1
+
+PORT=8080
+
+PROCESS_NAME=TEST
+
+# This is the load
+LOAD=0.5
+
+
+# This is an array
+NUMBERS=[1, 2, 3, 4, 5]
+
+EMPTY_ARRAY=[]
+
+

tests/unit-tests/test_config.c

@@ -120,4 +120,12 @@ context (test_config) {
 
     } end
 
+    describe("Double newline") {
+
+        it ("should not fail when the config file ends with two newlines") {
+            t_config *config = config_create("resources/config-double-newline.cfg");
+            config_destroy(config);
+        } end
+    } end
+
 }