Update to allow use with tox-uv
#11
Conversation
|
Do the tests need pip? Didn't see that in #10. It is needed for the entry point, of course. |
|
🤦 I thought to myself "surely I have a test for the pip-wrapper which will need this" and you're 100% right that it isn't needed. I'll consider that to be a testing gap which I can address separately. I'll back that out -- good catch! |
|
(And here I was about to pop over to #10 and say I was helping get it all set, but you're already on top of the changes. 😁 ) |
Some issues were raised when putting the repo through a trial run of `tox` with `tox-uv` installed. "pip" is not included in package dependencies, but the pip wrapper, `pip-install-dependency-groups` uses it. `tox` environments were still using the wrapper. To resolve, `tox.ini` is updated to use the new `dependency_groups` support from v4.22.0+
|
I can rebase after this, several things are better, like min version and skip install. :) |
| allowlist_externals = rm | ||
| changedir = docs/ | ||
| # clean the build dir before rebuilding | ||
| commands_pre = | ||
| pip-install-dependency-groups -f {toxinidir}/pyproject.toml docs |
There was a problem hiding this comment.
FWIW, I left this one to keep a run with pip-install-dependency-groups. but a proper test would be better.
There was a problem hiding this comment.
I'll work up some tests, so let's not worry about it and just get to a more ideal config. (But I'll probably focus on working up pip support before I come back to this, since ideally the pip wrapper can just be dropped in a 2.0 release at some point.)
There was a problem hiding this comment.
Personally, I think I'd prefer a dependency-groups command that produced a list of deps that I could feed to pip install or uv pip install or requirements.txt or whatever. :)
Some issues were raised when putting the repo through a trial run of
toxwithtox-uvinstalled."pip" is not included in package dependencies, but the pip wrapper,
pip-install-dependency-groupsuses it.To resolve,
tox.iniis updated to use the newdependency_groupssupport from v4.22.0+EDIT: this no longer adds
pipto thetestdeps.📚 Documentation preview 📚: https://dependency-groups--11.org.readthedocs.build/en/11/