Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate the errors from compilation and from the web service #5

Merged
merged 3 commits into from
Apr 23, 2020
Merged

Propagate the errors from compilation and from the web service #5

merged 3 commits into from
Apr 23, 2020

Conversation

daradermody
Copy link
Contributor

Compilation errors

Instead of this:
image
You get this:
image

Web service errors

Instead of this:
image
You get this:
image

akhileshbhatia
akhileshbhatia requested changes Apr 23, 2020
View reviewed changes
Copy link

@akhileshbhatia akhileshbhatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't quite understand where are we using the node typings?

app/templates/invoke Outdated Show resolved Hide resolved
app/templates/invoke Outdated Show resolved Hide resolved
@daradermody
Copy link
Contributor Author

Didn't quite understand where are we using the node typings?

To get typings for child_process.

akhileshbhatia
akhileshbhatia approved these changes Apr 23, 2020
View reviewed changes
Copy link

@akhileshbhatia akhileshbhatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daradermody daradermody merged commit 50378d5 into master Apr 23, 2020
@daradermody daradermody deleted the clearer-errors branch April 23, 2020 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akhileshbhatia akhileshbhatia akhileshbhatia approved these changes

@Verdagio Verdagio Awaiting requested review from Verdagio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daradermody @akhileshbhatia