[INVE-23376] Prevent errors from invocation test when folder is within Investigate folder #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll let @sibisimon review this one. Once it's merged, can you get a build and send it to Manu? |
daradermody
deleted the
fix-invoke-error-when-within-investigate-project
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Errors in the issue were being thrown because Typescript also looks at parent directories for types (e.g.
../node_modules/@types), which was causing conflicts. We can prevent this by settingtypeRootsexplicitly.Plus some other minor version bumps.
You can test this by running through the tutorial here, but instead of installing
@sirensolutions/generator-web-serviceusingnpm install -g, you checkout this branch and runnpm link. Then continue with the tutorial and generate the web service withinkibi-internal/pluginsand try out thenode invokecommand.