PHPCS: enforce tab indentation #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PHPCS ruleset as it was, didn't enforce space nor tab indentation. After discussion with sirbrillig, it became clear that tab indentation is preferred. This commit adjusts the ruleset to enforce tab indentation and updates all files to use tabs instead of spaces for indentation.
jrfnl
force-pushed
the
feature/cs-enforce-tabs
branch
from
71586f7 to
2398c78
Compare
|
Made one minor tweak to the ruleset, no other changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PHPCS ruleset as it was, didn't enforce space nor tab indentation.
After discussion with sirbrillig, it became clear that tab indentation is preferred.
This commit adjusts the ruleset to enforce tab indentation and updates all files to use tabs instead of spaces for indentation.