VariableAnalysisSniff::checkForCatchBlock(): fix comment tolerance #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP ignores comments in unexpected/unconventional places and so should the sniff. Includes adjusting an existing unit test. Without the fix, the adjusted unit test would cause test failures.
jrfnl
force-pushed
the
feature/checkforcatchblock-fix-comment-tolerance
branch
from
a017f67 to
cbb04a5
Compare
jrfnl
added a commit
to jrfnl/phpcs-variable-analysis
that referenced
this pull request
Feb 17, 2022
Using the `dealerdirect/phpcodesniffer-composer-installer` Composer plugin is recommended to register external PHPCS standards with PHPCS. As of Composer 2.2.0, Composer plugins need to be explicitly allowed to run. This commit: * Adds the necessary configuration for that to the `composer.json` for this project. * Adds the CLI command to set those permissions to the installation instructions for consumer projects. Includes updating the URL references to the plugin to point to the new home of the plugin. (see [upstream issue sirbrillig#146](PHPCSStandards/composer-installer#146)) Refs: * https://blog.packagist.com/composer-2-2/#more-secure-plugin-execution
sirbrillig
pushed a commit
that referenced
this pull request
Feb 21, 2022
Using the `dealerdirect/phpcodesniffer-composer-installer` Composer plugin is recommended to register external PHPCS standards with PHPCS. As of Composer 2.2.0, Composer plugins need to be explicitly allowed to run. This commit: * Adds the necessary configuration for that to the `composer.json` for this project. * Adds the CLI command to set those permissions to the installation instructions for consumer projects. Includes updating the URL references to the plugin to point to the new home of the plugin. (see [upstream issue #146](PHPCSStandards/composer-installer#146)) Refs: * https://blog.packagist.com/composer-2-2/#more-secure-plugin-execution Co-authored-by: jrfnl <jrfnl@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP ignores comments in unexpected/unconventional places and so should the sniff.
Includes adjusting an existing unit test.
Without the fix, the adjusted unit test would cause test failures.