Support constructor promotion with readonly properties (UnusedVariable)

[defunctl]

The following throws this error:

phpcs: VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable: Unused function parameter $message.

<?php declare(strict_types=1);

namespace MyProject;

final class Manager {

	public function __construct(
		private readonly string $message
	) {}

	public function getMessage(): string {
		return $this->message;
	}

}

PHP Version: 8.1
Variable Analysis Version: v2.11.10

[sirbrillig]

Interesting! Constructor promotion support was added in #266 but I bet that the readonly token could be breaking the logic.

[jrfnl]

@sirbrillig FYI, in case it helps: the PHPCS native File::getMethodParameters() method has support for both, but using that would require some changes in how things are being sniffed (or detection of a function declaration based on the parentheses surrounding parameters and using the method that way).

[jrfnl]

Just ran into this one myself now ;-)

[sirbrillig]

#294 should fix this.

[jrfnl]

Much appreciated @sirbrillig !