Skip to content

Conversation

@sipsorcery
Copy link
Member

No description provided.

@sipsorcery sipsorcery requested a review from Copilot September 22, 2025 19:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adjusts the way TURN client extensions obtain the remote peer IP address by replacing the RTPSession parameter with a direct IPAddress parameter and removing the event-based approach.

Key changes:

  • Modified TURN client API to accept remote peer IP address directly instead of deriving it from RTP session
  • Removed event-driven permission creation in favor of immediate permission setup
  • Added environment variable configuration for remote peer IP in example applications

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/net/TURN/TurnClientExtensions.cs Updated UseTurn method signature to accept IPAddress parameter directly and simplified permission creation
src/net/STUN/STUNClientExtensions.cs Added documentation remarks about potential issues with STUN approach
src/net/RTP/Streams/MediaStream.cs Removed TurnClient property and added debug logging for RTCP packets
src/net/RTP/RTPSession.cs Minor code style improvements and log message updates
examples/SIPExamples/UserAgentServer/Program.cs Added REMOTE_PEER_IP environment variable support and updated TURN usage
examples/SIPExamples/UserAgentClient/Program.cs Added REMOTE_PEER_IP environment variable support and updated TURN usage

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

sipsorcery and others added 2 commits September 22, 2025 20:31
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@sipsorcery sipsorcery merged commit 6f70952 into master Sep 22, 2025
@sipsorcery sipsorcery deleted the turnclient2 branch September 22, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants