Fix logic flow in DtlsSrtpTransport.cs #1316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RTC updates
use wyze camera name from url
Add timeout to ice gathering Add prefer H264 flag for compatible formats
Add sanity check for ICE Gathering timeout
Add sanity check for ICE Gathering timeout Fix bug in g722 codec
Fix bug where duplicate durations were being added to local track timestamp in SendAudioFrame Ignore H264 formats that use unsupported packetization modes Clean up logic in AreMatch
sipsorcery
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quite often I get exceptions in this method where it's closed before the handshake has completed so GetMillisecondsRemaining uses 1/1/0001 and returns a timeout of -2147463647 and throws a TimeoutException();
where It should be throwing
throw new System.Net.Sockets.SocketException((int)System.Net.Sockets.SocketError.NotConnected);