fix: shell path validation false positives and agent config merge#788
Open
xaxadobit wants to merge 1 commit intosipeed:mainfrom
Open
fix: shell path validation false positives and agent config merge#788xaxadobit wants to merge 1 commit intosipeed:mainfrom
xaxadobit wants to merge 1 commit intosipeed:mainfrom
Conversation
Bug 1: Shell path validation regex was capturing non-path strings - The regex /[^\s"']+ was matching escaped newlines (\n -> /n) - Also matched GitHub repo args (gh --repo owner/repo) - Fix: Only validate paths that exist on filesystem Bug 2: Agent-specific restrict_to_workspace was ignored - AgentConfig lacked RestrictToWorkspace field - instance.go always used defaults.RestrictToWorkspace - Fix: Add field to AgentConfig and use it when defined
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two critical issues:
1. Shell Path Validation False Positives
isValidShellPath()that was rejecting valid shells like/bin/shfilepath.Base()to extract the name first/bin/sh→ extracted "sh" but checked "sh" against "bin/sh" → ❌ rejected/bin/sh→ extract "sh" → check "sh" against "sh" → ✅ accepted2. Agent Config Not Merging
Test Plan
/bin/sh,/bin/bash,/usr/bin/bashRelated