New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed some bugs in the Serial implementations #111

Merged

Neutree merged 1 commit into sipeed:master from mikljohansson:fixed-uart-write-return-value

May 31, 2021

Contributor

mikljohansson commented Mar 13, 2021

tl;dr I fixed return value handling of UARTClass::write and Print::write

UARTClass::write was always return 0 as the number of bytes written. It should return 1, which is the number of bytes written to the UART
Print::write(buf, len) method wasn't considering the return values from the write(c) method
uarths_rec_callback() was using deprecated Kendryte SDK function uarths_getc()
HardwareSerial::availableForWrite() method wasn't exposed in the interface


          Fixed return value handling of UARTClass::write and Print::write

4f4d430

Neutree merged commit f54b3f1 into sipeed:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet