Merge bitcoin#498: tests: Avoid calling fclose(...) with an invalid argument

gmaxwell · gmaxwell · commit 7f9c1a15659b · 2018-02-06T23:04:51.000Z
5aae5b5 Avoid calling fclose(...) with an invalid argument (practicalswift) Pull request description: Avoid calling `fclose(...)` with an invalid argument. Tree-SHA512: f1a057b8c52089a3af1d9bfe97b751a4003b944d293147855eca452d1766c4ead5701d06f546153e654c9cb07b3fe2bcc4e28c8a54a27263d1e2434be123ca3b
diff --git a/src/tests.c b/src/tests.c
@@ -4929,7 +4929,9 @@ int main(int argc, char **argv) {
             seed16[6] ^= t >> 48;
             seed16[7] ^= t >> 56;
         }
-        fclose(frand);
+        if (frand) {
+            fclose(frand);
+        }
     }
     secp256k1_rand_seed(seed16);
 

Original file line number	Diff line number	Diff line change
`@@ -4929,7 +4929,9 @@ int main(int argc, char **argv) {`
`4929`	`4929`	`seed16[6] ^= t >> 48;`
`4930`	`4930`	`seed16[7] ^= t >> 56;`
`4931`	`4931`	`}`
`4932`		`- fclose(frand);`
	`4932`	`+ if (frand) {`
	`4933`	`+ fclose(frand);`
	`4934`	`+ }`
`4933`	`4935`	`}`
`4934`	`4936`	`secp256k1_rand_seed(seed16);`
`4935`	`4937`