Merge bitcoin#499: tests: Make sure we get the requested number of bytes from /dev/urandom

gmaxwell · gmaxwell · commit f99aa8d4d3a3 · 2018-02-06T23:00:25.000Z
82a96e4 tests: Make sure we get the requested number of bytes from /dev/urandom (practicalswift) Pull request description: Make sure we get the requested number of bytes from `/dev/urandom`. Tree-SHA512: 1b035942fd2a6ee2423fb2a2a0a0f294682c51434f86e5c106fb493d77f45aa8070662190aca6441fe389b8cdcc132d432517b8e826be2ac530a1511cd0c8919
diff --git a/src/tests.c b/src/tests.c
@@ -4918,7 +4918,7 @@ int main(int argc, char **argv) {
         }
     } else {
         FILE *frand = fopen("/dev/urandom", "r");
-        if ((frand == NULL) || !fread(&seed16, sizeof(seed16), 1, frand)) {
+        if ((frand == NULL) || fread(&seed16, sizeof(seed16), 1, frand) != sizeof(seed16)) {
             uint64_t t = time(NULL) * (uint64_t)1337;
             seed16[0] ^= t;
             seed16[1] ^= t >> 8;

Original file line number	Diff line number	Diff line change
`@@ -4918,7 +4918,7 @@ int main(int argc, char **argv) {`
`4918`	`4918`	`}`
`4919`	`4919`	`} else {`
`4920`	`4920`	`FILE *frand = fopen("/dev/urandom", "r");`
`4921`		`- if ((frand == NULL) \|\| !fread(&seed16, sizeof(seed16), 1, frand)) {`
	`4921`	`+ if ((frand == NULL) \|\| fread(&seed16, sizeof(seed16), 1, frand) != sizeof(seed16)) {`
`4922`	`4922`	`uint64_t t = time(NULL) * (uint64_t)1337;`
`4923`	`4923`	`seed16[0] ^= t;`
`4924`	`4924`	`seed16[1] ^= t >> 8;`