fix(flush-sets): avoids attempting to send more than one data type to the same metric #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… prints out headers (that have influxdb errors)
…(e.g. unique strings) as it will fail / not work properly
sioomy
approved these changes
May 12, 2018
|
Thank you for support this ! |
sioomy
approved these changes
May 12, 2018
|
No worries @sioomy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am sending UUID values in a set, in order to get a count of running instances. This currently spams 400 logs / may never work (depending on what is the first value seen by influx db, a string or an int).
This PR adds a log method for the response details on v1.4 flush error (outputs one line, contains headers, which contains influxdb error messages, very useful), and fixes the issue with sending more than one type of measurement by verifying that all values in the set will actually be sent as valid integers / are safe to send, before actually sending them (excluding them all if they contain one or more non-integer value, for example).