-
-
Notifications
You must be signed in to change notification settings - Fork 777
chore!: remove fakeXMLHttpRequest and fakeServer #2642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2642 +/- ##
==========================================
- Coverage 96.10% 96.05% -0.06%
==========================================
Files 40 40
Lines 1951 1926 -25
==========================================
- Hits 1875 1850 -25
Misses 76 76
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fatso83
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's time. We might want to add some notes to the migration-guide.md about alternatives (msw, etc).
BREAKING CHANGE: remove fakeXMLHttpRequest and fakeServer from the API
9a7967b to
4cdbfea
Compare
|
This has been published to the npm registry as part of |
I've created #2652 so we won't forget this |
BREAKING CHANGE: remove fakeXMLHttpRequest and fakeServer from the API
Times have changed, and people shouldn't be using these anymore, but prefer better options for testing their remote requests.
How to verify - mandatory
npm installnpm testChecklist for author
npm run lintpasses