Skip to content

Conversation

@mroderick
Copy link
Member

BREAKING CHANGE: remove fakeXMLHttpRequest and fakeServer from the API

Times have changed, and people shouldn't be using these anymore, but prefer better options for testing their remote requests.

How to verify - mandatory

  1. Check out this branch
  2. npm install
  3. npm test

Checklist for author

  • npm run lint passes
  • References to standard library functions are cached.

@mroderick mroderick added the semver:major changes will cause a new major version label Mar 17, 2025
@socket-security
Copy link

socket-security bot commented Mar 17, 2025

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

View full report↗︎

@codecov
Copy link

codecov bot commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.05%. Comparing base (e47cb9d) to head (4cdbfea).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2642      +/-   ##
==========================================
- Coverage   96.10%   96.05%   -0.06%     
==========================================
  Files          40       40              
  Lines        1951     1926      -25     
==========================================
- Hits         1875     1850      -25     
  Misses         76       76              
Flag Coverage Δ
unit 96.05% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@fatso83 fatso83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's time. We might want to add some notes to the migration-guide.md about alternatives (msw, etc).

BREAKING CHANGE: remove fakeXMLHttpRequest and fakeServer from the API
@mroderick mroderick force-pushed the remove-fakexhr-and-fakeserver branch from 9a7967b to 4cdbfea Compare March 24, 2025 18:06
@mroderick mroderick merged commit 95d4b8f into main Mar 24, 2025
13 of 14 checks passed
@mroderick mroderick deleted the remove-fakexhr-and-fakeserver branch March 24, 2025 18:08
@mroderick
Copy link
Member Author

This has been published to the npm registry as part of sinon@20.0.0

@mroderick
Copy link
Member Author

We might want to add some notes to the migration-guide.md about alternatives (msw, etc).

I've created #2652 so we won't forget this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver:major changes will cause a new major version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants