Skip to content

Conversation

@noisecapella
Copy link
Contributor

Purpose (TL;DR) - mandatory

Fixed missing reset of exceptionCreator for resolvesThis which exists in other similar functions. Where exception is set to undefined exceptionCreator should also be set to `undefined.

How to verify - mandatory

In the branch, remove the change to default-behaviors.js and run the tests. One of the two new tests should fail, showing that the previous behavior is inconsistent regarding how throws affects resolveThis.

Checklist for author

  • npm run lint passes
  • References to standard library functions are cached.

@fatso83 fatso83 merged commit 4310343 into sinonjs:master Aug 16, 2017
@mroderick mroderick added the semver:patch changes will cause a new patch version label Aug 22, 2017
@mroderick
Copy link
Member

Thank you 👍

@mroderick
Copy link
Member

This was released with sinon@3.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver:patch changes will cause a new patch version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants