Skip to content

Commit

Permalink
Simplify scripts using lifecycle events
Browse files Browse the repository at this point in the history
The WebWorker test in PR #1479 seems to fail for some mysterious
reason with a synchronous XHR requests. The reason was most
probably the importScript('../../pkg/sinon.js') call in the
webworker file was referencing a build file that wasn't built.

By now explicitly building this file as part of the test run
this error has now disappeared locally, and probably will
disappear on CircleCI as well.

fixes the build in #1479
  • Loading branch information
fatso83 committed Aug 1, 2017
1 parent d37ca03 commit 521a0f7
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,18 @@
"license": "BSD-3-Clause",
"scripts": {
"test-node": "mocha --recursive -R dot test/",
"test-dev": "npm run test-node -- --watch -R min",
"test-dev": "run-s test-node -- --watch -R min",
"test-headless": "mochify --recursive -R dot --grep WebWorker --invert --plugin [ proxyquire-universal ] test/",
"test-coverage": "mochify --recursive -R dot --grep WebWorker --invert --plugin [ mochify-istanbul --exclude '**/+(test|node_modules)/**/*' --report text --report lcovonly --dir ./coverage ] test/",
"test-cloud": "npm run test-headless -- --wd",
"test-cloud": "run-s test-headless -- --wd",
"test-webworker": "browserify --no-commondir --full-paths -p [ mocaccino -R spec --color ] test/webworker/webworker-support-assessment.js | phantomic --web-security false",
"test": "npm run test-node && npm run test-headless && npm run test-webworker",
"test": "run-s test-node test-headless test-webworker",
"build": "./build.js",
"lint": "eslint .",
"precommit": "lint-staged",
"prepublish": "rimraf pkg && ./build.js",
"pretest-webworker": "run-s build",
"prebuild": "rimraf pkg",
"prepublishOnly": "run -s build",
"preversion": "./scripts/preversion.sh",
"postversion": "./scripts/postversion.sh",
"eslint-pre-commit": "./scripts/eslint-pre-commit"
Expand Down Expand Up @@ -53,6 +56,7 @@
"mocha": "^3.1.2",
"mochify": "^3.0.0",
"mochify-istanbul": "^2.4.1",
"npm-run-all": "^4.0.2",
"phantomic": "^1.4.0",
"phantomjs-prebuilt": "^2.1.14",
"proxyquire": "^1.8.0",
Expand Down

0 comments on commit 521a0f7

Please sign in to comment.