Add missing expectation property for resolves/rejects #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When these assertions were introduced in 1af3c77, we overlooked the expectation property.
Codecov Report
@@ Coverage Diff @@
## master #185 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 81 81
Lines 652 652
=====================================
Hits 652 652
Continue to review full report at Codecov.
|
mantoni
approved these changes
Feb 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds missing expecation properties for
resolvesandrejectsassertions.Purpose
Improve support for the BDD style use of the library
Background
When these assertions were introduced in 1af3c77, we overlooked the expectation property.
Solution
Add the missing
expectationproperties.How to verify