Skip to content

Improve READMEs #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2021
Merged

Improve READMEs #2

merged 1 commit into from
Dec 17, 2021

Conversation

tri-adam
Copy link
Collaborator

Add link to Sylabs OpenAPI specification, and Go client module to Clients section.

Clarify that Singularity Enterprise is the commercial (for profit) implementation, not to be confused with the Sylabs Cloud Library, which isn't a commercial product (Sylabs operates that for free).

Add link to Sylabs OpenAPI specification, and Go client module to
'Clients' section. Add Singularity Enterprise as commercial
implementation, and move Sylabs Cloud Library to non-commercial
implementations.
Copy link
Member

@vsoch vsoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@vsoch
Copy link
Member

vsoch commented Dec 17, 2021

@tri-adam I'm going to merge here - could you look at (and approve) #1 and then I'll add everyone as maintainers on the repo?

@vsoch vsoch merged commit 7feef42 into singularityhub:main Dec 17, 2021
@tri-adam tri-adam deleted the improve-readmes branch December 17, 2021 19:14

The specification here is a community effort to document and maintain this application
programming interface.
programming interface. To support this effort, Sylabs has contributed the
[OpenAPI specification](https://github.com/sylabs/scs-library-client/blob/master/api/server/openapi.yml)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Is there a way to render this link in a more human-friendly form?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100%! Actually I do this with a bunch of pages for US-RSE - we can basically make a web request that retrieves and renders the spec, so we can keep it in one repository and render in another. Where should we put it - at the top of the current spec page rendered as yaml?

Let me know - I'm going to merge the charter and I can do a follow up PR with this.

Copy link

@dtrudg dtrudg Dec 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that there are a bunch of online sites that will render a nice view of an OpenAPI spec for you, e.g.

https://mrin9.github.io/OpenAPI-Viewer/

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right but isn't the idea to have it rendered in the same place as this repo (and not another site?)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or are you suggesting to take whatever libraries they use, and use them here?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to just use that hyperlink, it doesn't have to be rendered here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants