Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add connection to grammer #62

Merged
merged 2 commits into from
Jul 18, 2023
Merged

Add connection to grammer #62

merged 2 commits into from
Jul 18, 2023

Conversation

AmirHossein
Copy link
Contributor

Illuminate\Database\Grammer::escape functionality moved to Illuminate\Database\Connection::escape (commit) and it needs connection instance to work.
It used in toRawSql, dumpRawSql() and ddRawSql() new methods (#47507)

@AdalbertMemSQL
Copy link
Collaborator

@AmirHossein
Thanks for raising this issue. This change doesn't work with older versions of Laravel.
Can you fix it?

@AmirHossein
Copy link
Contributor Author

@AdalbertMemSQL
Changes on Connection including rawSql methods were introduced on Laravel 10. I updated PR to avoid error on other versions.

@AdalbertMemSQL AdalbertMemSQL merged commit b62e08b into singlestore-labs:main Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AmirHossein @AdalbertMemSQL