Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checking if file exist and if it does not create it #113

Conversation

tungurlakachakcak
Copy link
Contributor

Part of #98

Initially, the server breaks if there is no import map on the local filesystem.

After the changes, the server is creating the import map when it is missing and, when restarted, the file does not get reset.

Copy link
Member

@joeldenning joeldenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one comment

src/io-methods/filesystem.js Outdated Show resolved Hide resolved
Co-authored-by: Joel Denning <joeldenning@gmail.com>
Copy link
Member

@joeldenning joeldenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@joeldenning joeldenning merged commit ab06209 into single-spa:main May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants