[r] Add Arrow to R type mapper #3161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnkerl
approved these changes
Oct 10, 2024
| @@ -132,8 +132,7 @@ TileDBArray <- R6::R6Class( | |||
| #' @description Retrieve the array schema as an Arrow schema (lifecycle: maturing) | |||
| #' @return A [`arrow::schema`] object | |||
| schema = function() { | |||
| arrow::as_schema( | |||
| c_schema(self$uri, private$.soma_context)); | |||
| return(arrow::as_schema(c_schema(self$uri, private$.soma_context))) | |||
Add new `r_type_from_arrow_type()` function to get R types from Arrow types. This function takes an Arrow schema, field, or datatype and returns the corresponding R type (as indicated by `typeof()`) (or types for a schema) [SC-57387](https://app.shortcut.com/tiledb-inc/story/57387)
[ci skip]
Bump develop version [ci skip]
mojaveazure
force-pushed
the
paulhoffman/sc-57387/allow-accessing-an-r-ified-schema
branch
from
7b7c3f0
to
38da5ac
Compare
mojaveazure
deleted the
paulhoffman/sc-57387/allow-accessing-an-r-ified-schema
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new
r_type_from_arrow_type()function to get R types from Arrow types. This function takes an Arrow schema, field, or datatype and returns the corresponding R type (as indicated bytypeof()) (or types for a schema)I chose this route over modifiying the schema directly as modifying the schema turned out to be way harder than I anticipated (thanks to Arrow calling out to C/C++ for nearly all access)
SC-57387