Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Canned tests for old/new arrays without/with new shapes #3156

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Oct 9, 2024

Issue and/or context: As tracked on issue #2407 / [sc-51048].

Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.

Changes:

Here we keep around an old-style experiment to regress on our ability to upgrade its shapes.

For this PR we only test accessors on the data. On #3148 these unit test will be extended to check their upgrading of the old-style experiment.

Notes for Reviewer:

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.13%. Comparing base (46bf2ec) to head (880e26b).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3156      +/-   ##
==========================================
+ Coverage   82.92%   83.13%   +0.20%     
==========================================
  Files          50       50              
  Lines        5236     5247      +11     
==========================================
+ Hits         4342     4362      +20     
+ Misses        894      885       -9     
Flag Coverage Δ
python 83.13% <ø> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 83.13% <100.00%> (+0.20%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@johnkerl
Copy link
Member Author

johnkerl commented Oct 9, 2024

Thanks @nguyenv ! :)

@johnkerl johnkerl merged commit 7b09dd7 into main Oct 9, 2024
11 checks passed
@johnkerl johnkerl deleted the kerl/py-exp-shaping branch October 9, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants