-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[c++] Fix sanitizer flags and move from an option to a config type #3150
Conversation
6880ccf
to
e8ddba3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3150 +/- ##
==========================================
+ Coverage 83.22% 83.33% +0.10%
==========================================
Files 51 51
Lines 5462 5462
==========================================
+ Hits 4546 4552 +6
+ Misses 916 910 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as long as the sanitizer is sanitizing
I defer to @nguyenv here ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as long as the sanitizer is sanitizing
I defer to @nguyenv here ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might have been cleaner if the sanitizer was an option separate from the config, and either accept that it will work only in Debug mode, or enforce it by setting CMAKE_CONFIGURATION_TYPES
to only Debug
.
Co-authored-by: Theodore Tsirpanis <theodore.tsirpanis@tiledb.com>
The builds using the
SANITIZER
option were missing the linker flags necessary to build. This PR adds those back in and moves enabling sanitizers to a config option. The new build types are enabled:ASAN
: address sanitizerTSAN
: thread sanitizerLSAN
: leak sanitizerMSAN
: memory sanitizerUBSAN
: undefined-behavior sanitizer