Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c++] Unit-test the dataframe upgrader #3139

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Oct 6, 2024

Issue and/or context: As tracked on issue #2407 / [sc-51048].

Changes:

Unit-test the dataframe upgrader.

Notes for Reviewer:

@johnkerl johnkerl requested a review from nguyenv October 6, 2024 15:22
@johnkerl johnkerl changed the title [c++] Unit-test dataframe upgraders [c++] Unit-test the dataframe upgrader Oct 6, 2024
@johnkerl johnkerl force-pushed the kerl/cpp-dataframe-upgrade-test branch from 997d077 to ae4eb45 Compare October 6, 2024 15:28
Copy link

codecov bot commented Oct 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.16%. Comparing base (7018462) to head (3f5850b).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3139      +/-   ##
==========================================
+ Coverage   82.41%   83.16%   +0.75%     
==========================================
  Files          50       50              
  Lines        5203     5198       -5     
==========================================
+ Hits         4288     4323      +35     
+ Misses        915      875      -40     
Flag Coverage Δ
python 83.16% <ø> (+0.75%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 83.16% <ø> (+0.75%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@johnkerl johnkerl requested a review from nguyenv October 8, 2024 16:51
@johnkerl
Copy link
Member Author

johnkerl commented Oct 8, 2024

Thanks @nguyenv !

@johnkerl johnkerl merged commit 6b65790 into main Oct 8, 2024
15 checks passed
@johnkerl johnkerl deleted the kerl/cpp-dataframe-upgrade-test branch October 8, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants