Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Add the Python implementation of the Scene collection #3116

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

jp-dark
Copy link
Collaborator

@jp-dark jp-dark commented Oct 2, 2024

Adds the Python implementation of the new Scene collection class.

Issue: #3040

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 39 lines in your changes missing coverage. Please review.

Project coverage is 86.68%. Comparing base (2dab4e9) to head (16124cc).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3116       +/-   ##
===========================================
+ Coverage   63.20%   86.68%   +23.48%     
===========================================
  Files         113       47       -66     
  Lines       14228     4920     -9308     
  Branches      855        0      -855     
===========================================
- Hits         8993     4265     -4728     
+ Misses       5027      655     -4372     
+ Partials      208        0      -208     
Flag Coverage Δ
libtiledbsoma ?
python 86.68% <66.66%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 86.68% <66.66%> (-0.11%) ⬇️
libtiledbsoma ∅ <ø> (∅)

Copy link
Member

@nguyenv nguyenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; minor typos in docstrings

apis/python/src/tiledbsoma/_scene.py Outdated Show resolved Hide resolved
apis/python/src/tiledbsoma/_scene.py Outdated Show resolved Hide resolved
apis/python/src/tiledbsoma/_scene.py Outdated Show resolved Hide resolved
Co-authored-by: nguyenv <vivian@tiledb.com>
@jp-dark jp-dark merged commit 0a9bf28 into main Oct 2, 2024
21 checks passed
@jp-dark jp-dark deleted the dark/scene-python/sc-50269 branch October 2, 2024 20:36
@johnkerl johnkerl changed the title Add the Python implementation of the Scene collection [python] Add the Python implementation of the Scene collection Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants