[python] Create Group base class for Collection
#3024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnkerl
changed the title
Group base class for Collection
jp-dark
changed the title
Group base class for CollectionGroup base class for Collection
This change moves functionality from the python `Collection` class into a `Group` class. This is a precursor for the new `MultiscaleImage` class that is a TileDB group, but not a SOMA `Collection`
jp-dark
force-pushed
the
dark/refactor-group
branch
from
c96fe7f
to
1c02253
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3024 +/- ##
==========================================
+ Coverage 89.64% 89.85% +0.20%
==========================================
Files 40 41 +1
Lines 4096 4111 +15
==========================================
+ Hits 3672 3694 +22
+ Misses 424 417 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nguyenv
approved these changes
Sep 23, 2024
johnkerl
approved these changes
Sep 23, 2024
|
[sc-55580] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #3023
Changes: This change moves functionality from the python
Collectionclass into a newGroupclass. This is a precursor for the newMultiscaleImageclass that is a TileDB group, but not a SOMACollectionNotes for Reviewer: This change is primarily code movement.