Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Docstring typo, test-assertion msgs, maybe_raises improvement, verify_logs helper #2892

Merged
merged 3 commits into from
Aug 15, 2024

Conversation

ryan-williams
Copy link
Member

@ryan-williams ryan-williams commented Aug 14, 2024

Issue and/or context:

Changes:

  • maybe_raises can be passed a str (to match against an error message, regardless of error type) or an (exc, msg) tuple (to match against error type as well as message. As before, this is useful for tests where some cases expect no error, while others want to verify an error's class and/or message.
  • tests._util.verify_logs helper, which can verify presence of expected log messages, given a pytest "caplog" fixture

@ryan-williams ryan-williams marked this pull request as ready for review August 14, 2024 14:05
Base automatically changed from rw/uns to main August 14, 2024 21:17
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.03%. Comparing base (1e64fdd) to head (015ad0f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2892      +/-   ##
==========================================
+ Coverage   89.88%   90.03%   +0.15%     
==========================================
  Files          37       37              
  Lines        3925     3925              
==========================================
+ Hits         3528     3534       +6     
+ Misses        397      391       -6     
Flag Coverage Δ
python 90.03% <ø> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 90.03% <ø> (+0.15%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@johnkerl johnkerl changed the title [python] docstring typo, test-assertion msgs, maybe_raises improvement, verify_logs helper [python] Docstring typo, test-assertion msgs, maybe_raises improvement, verify_logs helper Aug 14, 2024
@ryan-williams ryan-williams merged commit f6c9686 into main Aug 15, 2024
11 checks passed
@ryan-williams ryan-williams deleted the rw/uu-base branch August 15, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants