Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #1690 to release-1.4 #1794

Merged
merged 5 commits into from
Oct 18, 2023
Merged

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Oct 17, 2023

Following #1690 (comment)

To get green CI I needed to update R CI to install 0.20.3 which gets core 2.16, which is essential since 0.21/2.17 do now exist

@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files Coverage Δ
...n/src/tiledbsoma/options/_tiledb_create_options.py 92.96% <100.00%> (+0.05%) ⬆️
apis/python/src/tiledbsoma/_dataframe.py 96.65% <85.71%> (-0.32%) ⬇️
apis/python/src/tiledbsoma/_dense_nd_array.py 95.65% <66.66%> (-2.13%) ⬇️
apis/python/src/tiledbsoma/_sparse_nd_array.py 88.46% <57.14%> (-2.63%) ⬇️
apis/python/src/tiledbsoma/_tiledb_array.py 83.65% <33.33%> (-12.18%) ⬇️

... and 74 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@johnkerl johnkerl changed the title cherry pick Backport #1690 to release-1.4 Oct 17, 2023
@johnkerl johnkerl marked this pull request as ready for review October 17, 2023 22:52
@johnkerl johnkerl merged commit 79a6f0f into release-1.4 Oct 18, 2023
8 checks passed
@johnkerl johnkerl deleted the backport-1690-to-release-1.4 branch October 18, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants