Skip to content

Commit

Permalink
code-review feedback: TypedDict -> attrs
Browse files Browse the repository at this point in the history
Co-authored-by: nguyenv <vivian@tiledb.com>
  • Loading branch information
johnkerl and nguyenv authored Oct 9, 2024
1 parent fff5c72 commit 4b9f4f4
Showing 1 changed file with 9 additions and 12 deletions.
21 changes: 9 additions & 12 deletions apis/python/src/tiledbsoma/io/shaping.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,18 +18,15 @@
Printable = Union[io.TextIOWrapper, io.StringIO]


class SizingArgs(TypedDict):
"""Convenience type-alias for kwargs passed to experiment-level
upgrade/resize functions.
"""

nobs: Optional[int]
nvars: Optional[Dict[str, int]]
ms_name: Optional[str]
coll_name: Optional[str]
verbose: bool
check_only: bool
context: Optional[tiledbsoma.SOMATileDBContext]
@attr.s(auto_attribs=True, frozen=True)
class SizingArgs:
nobs: Optional[int] = None
nvars: Optional[Dict[str, int]] = None
ms_name: Optional[str] = None
coll_name: Optional[str] = None
verbose: bool = True
check_only: bool = True
context: Optional[tiledbsoma.SOMATileDBContext] = None
output_handle: Printable


Expand Down

0 comments on commit 4b9f4f4

Please sign in to comment.