Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move basic Python configuration to the root of the repo. #80

Merged
merged 1 commit into from
Jan 14, 2023

Conversation

thetorpedodog
Copy link
Contributor

After way too much trying to figure stuff out I realized: why not just put the pyproject.toml right at the root of the repo? This eliminates all the #subdirectory=... when doing pip installs and also makes setuptools-scm work right again. As a bonus, lots of tools now work without any additional configuration and we can just run them as-is.

This moves the bare minimum files needed to the repo root:

  • pyproject.toml
  • MANIFEST.in

and updates everything else to make that work right.

@thetorpedodog
Copy link
Contributor Author

haha whoops

@thetorpedodog thetorpedodog marked this pull request as draft January 14, 2023 00:44
After way too much trying to figure stuff out I realized: why not just
put the `pyproject.toml` right at the root of the repo? This eliminates
all the `#subdirectory=...` when doing `pip install`s and also makes
`setuptools-scm` work right again. As a bonus, lots of tools now work
without any additional configuration and we can just run them as-is.

This moves the bare minimum files needed to the repo root:

- `pyproject.toml`
- `MANIFEST.in`

and updates everything else to make that work right.
@thetorpedodog
Copy link
Contributor Author

we’re back

@thetorpedodog thetorpedodog marked this pull request as ready for review January 14, 2023 01:12
Copy link
Member

@bkmartinjr bkmartinjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants