Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove optional keyword args from IndexLike.get_indexer #190

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Remove optional keyword args from IndexLike.get_indexer #190

merged 1 commit into from
Mar 22, 2024

Conversation

jp-dark
Copy link
Collaborator

@jp-dark jp-dark commented Mar 22, 2024

We only use the target positional argument from the pandas Index.get_indexer method. Remove optional keyword arguments to allow greater flexibility when implementing a IndexLike class.

@jp-dark jp-dark merged commit f8bdce6 into main Mar 22, 2024
8 checks passed
@jp-dark jp-dark deleted the dark/refine-indexlike-protocol branch March 22, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thetorpedodog thetorpedodog thetorpedodog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jp-dark @thetorpedodog