Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to mypy v1.0.0 and simplify pre-commit setup #117

Merged
merged 2 commits into from
Feb 8, 2023
Merged

Conversation

thetorpedodog
Copy link
Contributor

The somacore side of single-cell-data/TileDB-SOMA#905. Finally, no more _Self hacks here either.

Copy link
Member

@johnkerl johnkerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@thetorpedodog
Copy link
Contributor Author

minor update to remove the isort job from github actions now that it's obviated by ruff

This updates pre-commit and the recommended development environment
to use mypy v1.0.0 and regenerates all the `requirements.txt` files
based on this. Also has `ruff` play the role of `isort` since that was
causing issues in a new pre-commit setup (and is no longer needed).
@thetorpedodog thetorpedodog merged commit 02bb4e2 into main Feb 8, 2023
@thetorpedodog thetorpedodog deleted the mypy-v1 branch February 8, 2023 18:56
@johnkerl johnkerl changed the title Upgrade to mypy v1.0.0 and simplify pre-commit setup. Upgrade to mypy v1.0.0 and simplify pre-commit setup Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants