Skip to content

Commit

Permalink
Sync domain argument between Collection.add_new_dataframe and `Da…
Browse files Browse the repository at this point in the history
…taFrame.create` (#233)
  • Loading branch information
johnkerl authored Oct 3, 2024
1 parent e92ecb4 commit c840b73
Showing 1 changed file with 11 additions and 1 deletion.
12 changes: 11 additions & 1 deletion python-spec/src/somacore/collection.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,14 @@
import abc
from typing import Any, MutableMapping, Optional, Sequence, Type, TypeVar, overload
from typing import (
Any,
MutableMapping,
Optional,
Sequence,
Tuple,
Type,
TypeVar,
overload,
)

import pyarrow as pa
from typing_extensions import Final, Self
Expand Down Expand Up @@ -145,6 +154,7 @@ def add_new_dataframe(
uri: Optional[str] = None,
schema: pa.Schema,
index_column_names: Sequence[str] = (options.SOMA_JOINID,),
domain: Optional[Sequence[Optional[Tuple[Any, Any]]]] = None,
platform_config: Optional[options.PlatformConfig] = None,
) -> data.DataFrame:
"""Creates a new DataFrame as a child of this collection.
Expand Down

0 comments on commit c840b73

Please sign in to comment.