Fix: Issue with single character formatting in the toggle style button . #2597
+89
−47
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed the issue with single character formatting in the toggle style button. Previously, when formatting a single character (e.g., making it bold), the toolbar state was incorrectly affected, causing subsequent text to be formatted by default. This was due to using the incorrect
length
property onTextSelection
.The fix replaces
selection.length
withselection.end - selection.start
to properly check the selection length, ensuring that single character formatting doesn't affect the toolbar state while maintaining the correct behavior for multiple character selections.Related Issues
Type of Change
Changes Made
toggle_style_button.dart
to use correct TextSelection length calculationTesting