revert: "Resolved issue with broken IME composing rect in Windows desktop" #2266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singerdmx
approved these changes
Sep 22, 2024
CatHood0
added a commit
to CatHood0/flutter-quill
that referenced
this pull request
Oct 28, 2024
…ktop" (singerdmx#2266) * revert: Resolved issue with broken IME composing rect in Windows desktop * Chore: dart format --------- Co-authored-by: CatHood0 <santiagowmar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These changes were reverted because they are causing issues when using the indentation attribute. I can't say if they are causing other parts to fail, but they are definitely not allowing the editor to work stably.
@agata if you are going to redo your PR fixing this IME issue, please make sure to test if the IME works along with everything else in the editor (selection, typing, applying block and inline attributes, etc.) to make sure the change is really stable.
No related: I've noticed that on the web this fails randomly too.
Related Issues
Fix Applying indent attribute throws
container.containsOffset(position.offset)fail assertion #2253✨ New feature: Adds new functionality without breaking existing features.
🛠️ Bug fix: Resolves an issue without altering current behavior.
🧹 Code refactor: Code restructuring that does not affect behavior.
❌ Breaking change: Alters existing functionality and requires updates.
🧪 Tests: Adds new tests or modifies existing tests.
📝 Documentation: Updates or additions to documentation.
🗑️ Chore: Routine tasks, or maintenance.
✅ Build configuration change: Changes to build or deploy processes.
Suggestions
Before merging any new changes into the main release, we should consider whether these changes work completely without damaging the other existing functionality within the package.
We should establish some step-by-step guide before merging which PR to first check whether the changes really do not alter the correct functioning of the editor.