Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate markdown_quill export, ignore warnings #2256

Merged
merged 1 commit into from
Sep 21, 2024

Conversation

EchoEllet
Copy link
Collaborator

@EchoEllet EchoEllet commented Sep 21, 2024

Description

Deprecate markdown_quill.dart export as support for markdown conversation has been discounted (#1997).

It seems that we have deprecated DeltaX completely and related packages but didn't deprecate the file markdown_quill.dart. We should give users more time before introducing a breaking change.

There was questions about this API in Slack and it was confusing to the user since the project no longer has plan to keep the experimental support for those methods, we should be able to remove them since they are experimental but for this file, it wasn't clear enough.

The quill_markdown (from lib/src/packages/quill_markdown) is a local copy of quill_markdown. There were some bug fixes made in our local changes and did plan on sending them to the upstream repo before completely removing this package from the project however it seems that this package is no longer maintained.

Related Issues

Type of Change

  • New feature: Adds new functionality without breaking existing features.
  • 🛠️ Bug fix: Resolves an issue without altering current behavior.
  • 🧹 Code refactor: Code restructuring that does not affect behavior.
  • Breaking change: Alters existing functionality and requires updates.
  • 🧪 Tests: Adds new tests or modifies existing tests.
  • 📝 Documentation: Updates or additions to documentation.
  • 🗑️ Chore: Routine tasks, or maintenance.
  • Build configuration change: Changes to build or deploy processes.

@EchoEllet EchoEllet marked this pull request as ready for review September 21, 2024 02:08
@EchoEllet EchoEllet merged commit 75bc38a into master Sep 21, 2024
2 checks passed
CatHood0 pushed a commit to CatHood0/flutter-quill that referenced this pull request Sep 21, 2024
@EchoEllet EchoEllet deleted the chore/deprecate-markdown-quill-export branch October 27, 2024 13:28
CatHood0 pushed a commit to CatHood0/flutter-quill that referenced this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant