Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: refactor build leading function style, width, and padding parameters for custom node leading builder #2182

Merged
merged 3 commits into from
Sep 5, 2024

Conversation

EchoEllet
Copy link
Collaborator

Description

Move the style logic from a conditional expression into a function call for improved readability.

The refactoring simplifies the code by replacing nested ternary operators with if statements, improving the readability a bit.

Related Issues

Type of Change

  • New feature: Adds new functionality without breaking existing features.
  • 🛠️ Bug fix: Resolves an issue without altering current behavior.
  • 🧹 Code refactor: Code restructuring that does not affect behavior.
  • Breaking change: Alters existing functionality and requires updates.
  • 🧪 Tests: Adds new tests or modifies existing tests.
  • 📝 Documentation: Updates or additions to documentation.
  • 🗑️ Chore: Routine tasks, or maintenance.
  • Build configuration change: Changes to build or deploy processes.

Copy link
Collaborator

@CatHood0 CatHood0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hadn't thought of this! This refactoring makes it much easier for anyone to read. Thanks for the change.

We could use this PR to do the same with other parameters that have this one.

@EchoEllet EchoEllet marked this pull request as ready for review September 5, 2024 12:37
@EchoEllet EchoEllet changed the title style: refactor build leading function style parameter for custom node leading builder style: refactor build leading function style, width, and padding parameters for custom node leading builder Sep 5, 2024
Copy link
Collaborator

@CatHood0 CatHood0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for taking the time to do these changes.

@singerdmx singerdmx merged commit b3a103e into master Sep 5, 2024
2 checks passed
@EchoEllet EchoEllet deleted the refactor/style-check-custom-leading-builder branch September 14, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants